fix(web): show pending review toast for non-admin skill publish#84
Closed
yun-zhi-ztl wants to merge 24 commits intomainfrom
Closed
fix(web): show pending review toast for non-admin skill publish#84yun-zhi-ztl wants to merge 24 commits intomainfrom
yun-zhi-ztl wants to merge 24 commits intomainfrom
Conversation
The resolveStatusLabel and resolveStatusClassName functions were missing the REJECTED case, causing rejected skills to show raw status string with no color styling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backend: added version count check in SkillGovernanceService.deleteVersion() Frontend: hide delete button when only one version remains Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix deleteVersion_removesDraftFilesAndBundle: mock findBySkillId to return 2 versions so the new guard doesn't block the happy path - Add deleteVersion_rejectsLastRemainingVersion: verify that deleting the only remaining version is rejected with the correct error code
Non-admin users now see "Submitted for Review" instead of "Published Successfully" after uploading a skill, based on the status returned by the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a non-admin user uploads a skill, the toast message always shows "Published Successfully" (发布成功). This is misleading because non-admin users' skills go through a review process and are not immediately published.
Root Cause
The frontend publish handler did not check the
statusfield in the backend response. The backend correctly returnsPENDING_REVIEWfor non-admin users andPUBLISHEDfor admins, but the toast always displayed the same message.Fix
result.statusafter publish and show the appropriate toast:PUBLISHED: "Published Successfully" / "发布成功"PENDING_REVIEW: "Submitted for Review" / "已提交审核"Files Changed
web/src/pages/dashboard/publish.tsx— branch toast by statusweb/src/i18n/locales/en.json— add published/pending review messagesweb/src/i18n/locales/zh.json— add published/pending review messages